Some users were having problems with incomplete titles in Gmail. That was caused by not having an AOSP build of the TextUtils.smali file in these ROMs. I had a problem myself using my patch on the Galaxy S JVH ROM.

This new patch separates added methods from TextUtils.java that the CM7 team have added into a new class under android/text/util/RTLTextUtils. That way, we don’t need to replace this file from Stock and hopefully won’t have any disappearing titles in Gmail anymore.

Because of this new modification, the gingerbread patch should also work flawlessly on Froyo AOSP builds now (you get some updated tidbits from the modified files as a bonus).

For (1) I have created a new icu4c library that exposes these arabic shaping methods. This library should be portable across devices which means we won’t have to recompile libandroid_runtime.so for each device separately. My work can be seen at:
https://github.com/madmack/pla…

As for (2), the guys responsible for the Hebrew patch have produced a hex editor tool that can rename the function without having to recompile libandroid_runtime.so. This utility is called LibPatcher.exe and it simply takes your compiled libandroid_runtime.so and produces a fixed one with the correct naming scheme.

Given that these two things are taken care, we have Gingerbread AOSP patched correctly:
https://github.com/madmack/platform_frameworks_base/compare/arabic_gb_patch

While this should be backward compatible with Froyo AOSP builds, I was having a problem in Gmail’s title’s: a “Rejected.” string was appended to the end of each title. It seems that the Gmail app in Froyo is expecting a certain text to be returned and its not, but I couldn’t find the problem so far specially given how close the Froyo AOSP sources are to Gingerbread in these patched files.(update 4/13/2011) This has been fixed. Problem was with TextUtils.java. Simply recompiling my patch in Froyo’s AOSP build and cherry-picking TextUtils’ additions fixed it. My latest patch 0.800 should work with Froyo builds and Gingerbread now.

The other problem we have is with Sense UI in HTC’s new Gingerbread builds. HTC decided to modify Layout.java (in framework/base/core/java/android/text/) and this breaks the patch if replaced with AOSP’s compiled patched files. I fixed this tiny problem by applying the Hebrew java patch to Layout.smali.

So far the new patch basically applies to all Gingerbread ROMs except the ones based on Sense UI.

While this patch is speedy and takes care of the space after LAMALEF, it still has some spacing issues when typing text and its missing visual-to-logical functions to make the cursor fall exactly where the text appears for the user. For example, typing a sentence in arabic and then going back to modify somewhere in the middle will place your newly typed letters in unexpected positions in the sentence instead of it being exactly where the cursor is. So make sure you get the strings typed correctly on first shot

As always, my work is staying open sourced, so there you have it for those who are interested.

تحديث 14/4/2011: بعض الإخوان طلبوا شرح كيفية تعريب المتصفح. الباتش المستخدم هو من هذا المصدر. بعد رفع تعديلات الشركات لwebcore، تقوم بعمل الباتش ومن ثم recompile على أجهزة linux.
تحديث بتاريخ 16/8/2011: لقد تم اغلاق هذه الصفحة ومنع الطلبات في الوقت الراهن لإني قد توصلت مع أخي brightidea لحل أفضل وسيكون تعريب المتصفح متوافر مع framework في صفحة “طريقة التعريب”.

I have just successfully compiled and tested the arabic patch on AOSP 2.3.3. My old patch for 2.2 AOSP worked for all the files except TextUtils.java which Google added a new method to. Replacing it with CM7′s TextUtils.java file, which is based on Gingerbread, fixed that error.

HTC’s implementation of Gingerbread broke another file, Layout.java which they added a couple of new methods to. The fix was to manually edit HTC’s Layout.smali file and replace the strings getChars (3x occurrences) with getCharsDraw manually. A proper fix would be to include a utility that searches and replaces for these strings. This will guarantee functionality across all devices that sport Eclair and higher versions of Android.

Edit: HTC’s Gingerbread Sense UI also modified internal class CharWrapper in TextView.java. A small modification to the smali file in method “access”‘s signature fixed it.

Please use the links to the right for more details on how to apply them.

Most available patches are either not open sourced or are device specific. I attempt to make a global solution to our problem by providing a patching tool that should apply to any ROM by replacing the specific patched files. This should hopefully not break device specific implementations such as TouchWiz from Samsung, Sense UI from HTC or Motoblur from Motorola.

I have been following work for Y6b and dudyk over at github. Unfortunately both of their work was made for Cyanogenmod and not for AOSP. They also do change code in the JNI implementation which further makes this harder to port to several devices. I changed their code slightly to not require these modified JNI implementations and to have an independent framework.jar that will be easy to port.

Most of my code on github is composed of y6b’s and dudyk’s (see source code page for details). Namely I used y6b’s implementation for the shaping by importing the ICU4J library, and dudyk’s RTL alignments.

Again, all details should be on the two pages linked on the right panel.

]]> http://blog.devasque.com/2011/02/14/%d8%b7%d8%b1%d9%8a%d9%82%d8%a9-%d8%aa%d8%b9%d8%b1%d9%8a%d8%a8-%d8%a3%d9%86%d8%af%d8%b1%d9%88%d9%8a%d8%af-%d8%a8%d9%86%d8%b8%d8%a7%d9%85-2-2-%d9%88-2-2-1/feed/ 24